eslint-plugin-import: Enable more checks (#2366)

Author: IvanGoncharov

.eslintrc.yml

@@ -76,7 +76,7 @@ rules:
   import/no-webpack-loader-syntax: error
   import/no-self-import: error
   import/no-cycle: off # TODO
-  import/no-useless-path-segments: off # TODO
+  import/no-useless-path-segments: error
   import/no-relative-parent-imports: off
 
   # Helpful warnings
@@ -98,12 +98,12 @@ rules:
 
   # Style guide
   # https://github.com/benmosher/eslint-plugin-import#style-guide
-  import/first: off # TODO
+  import/first: error
   import/exports-last: off
   import/no-duplicates: error
   import/no-namespace: error
   import/extensions: [error, never] # TODO: switch to ignorePackages
-  import/order: off # TODO
+  import/order: error
   import/newline-after-import: error
   import/prefer-default-export: off
   import/max-dependencies: off

resources/gen-changelog.js

@@ -4,9 +4,11 @@
 
 const util = require('util');
 const https = require('https');
-const { exec } = require('./utils');
+
 const packageJSON = require('../package.json');
 
+const { exec } = require('./utils');
+
 const graphqlRequest = util.promisify(graphqlRequestImpl);
 const labelsConfig = {
   'PR: breaking change 💥': {

src/language/__tests__/schema-parser-test.js

@@ -5,10 +5,11 @@ import { describe, it } from 'mocha';
 
 import dedent from '../../jsutils/dedent';
 
+import { kitchenSinkSDL } from '../../__fixtures__';
+
 import { parse } from '../parser';
 
 import toJSONDeep from './toJSONDeep';
-import { kitchenSinkSDL } from '../../__fixtures__';
 
 function expectSyntaxError(text) {
   return expect(() => parse(text)).to.throw();

src/language/printLocation.js

@@ -1,8 +1,8 @@
 // @flow strict
 
-import { type Location } from '../language/ast';
-import { type Source } from '../language/source';
-import { type SourceLocation, getLocation } from '../language/location';
+import { type Location } from './ast';
+import { type Source } from './source';
+import { type SourceLocation, getLocation } from './location';
 
 /**
  * Render a helpful description of the location in the GraphQL Source document.

src/type/__tests__/validation-test.js

@@ -8,9 +8,13 @@ import inspect from '../../jsutils/inspect';
 
 import { parse } from '../../language/parser';
 
-import { GraphQLSchema } from '../../type/schema';
-import { GraphQLString } from '../../type/scalars';
-import { GraphQLDirective } from '../../type/directives';
+import { extendSchema } from '../../utilities/extendSchema';
+import { buildSchema } from '../../utilities/buildASTSchema';
+
+import { GraphQLSchema } from '../schema';
+import { GraphQLString } from '../scalars';
+import { GraphQLDirective } from '../directives';
+import { validateSchema, assertValidSchema } from '../validate';
 import {
   type GraphQLNamedType,
   type GraphQLInputType,
@@ -23,12 +27,7 @@ import {
   GraphQLUnionType,
   GraphQLEnumType,
   GraphQLInputObjectType,
-} from '../../type/definition';
-
-import { extendSchema } from '../../utilities/extendSchema';
-import { buildSchema } from '../../utilities/buildASTSchema';
-
-import { validateSchema, assertValidSchema } from '../validate';
+} from '../definition';
 
 const SomeScalarType = new GraphQLScalarType({ name: 'SomeScalar' });
 

src/utilities/schemaPrinter.js

@@ -32,7 +32,7 @@ import {
   isInputObjectType,
 } from '../type/definition';
 
-import { astFromValue } from '../utilities/astFromValue';
+import { astFromValue } from './astFromValue';
 
 type Options = {|
   /**

src/validation/specifiedRules.js

@@ -84,6 +84,15 @@ import { OverlappingFieldsCanBeMerged } from './rules/OverlappingFieldsCanBeMerg
 // Spec Section: "Input Object Field Uniqueness"
 import { UniqueInputFieldNames } from './rules/UniqueInputFieldNames';
 
+// SDL-specific validation rules
+import { LoneSchemaDefinition } from './rules/LoneSchemaDefinition';
+import { UniqueOperationTypes } from './rules/UniqueOperationTypes';
+import { UniqueTypeNames } from './rules/UniqueTypeNames';
+import { UniqueEnumValueNames } from './rules/UniqueEnumValueNames';
+import { UniqueFieldDefinitionNames } from './rules/UniqueFieldDefinitionNames';
+import { UniqueDirectiveNames } from './rules/UniqueDirectiveNames';
+import { PossibleTypeExtensions } from './rules/PossibleTypeExtensions';
+
 /**
  * This set includes all validation rules defined by the GraphQL spec.
  *
@@ -119,14 +128,6 @@ export const specifiedRules = Object.freeze([
   UniqueInputFieldNames,
 ]);
 
-import { LoneSchemaDefinition } from './rules/LoneSchemaDefinition';
-import { UniqueOperationTypes } from './rules/UniqueOperationTypes';
-import { UniqueTypeNames } from './rules/UniqueTypeNames';
-import { UniqueEnumValueNames } from './rules/UniqueEnumValueNames';
-import { UniqueFieldDefinitionNames } from './rules/UniqueFieldDefinitionNames';
-import { UniqueDirectiveNames } from './rules/UniqueDirectiveNames';
-import { PossibleTypeExtensions } from './rules/PossibleTypeExtensions';
-
 /**
  * @internal
  */