TS: switch to 'Array<*>' style of array types (#2387)

Author: IvanGoncharov

.eslintrc.yml

@@ -446,7 +446,7 @@ overrides:
       # Supported Rules
       # https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#supported-rules
       '@typescript-eslint/adjacent-overload-signatures': error
-      '@typescript-eslint/array-type': off # TODO [error, { default: generic }]
+      '@typescript-eslint/array-type': [error, { default: generic }]
       '@typescript-eslint/await-thenable': off # TODO error
       '@typescript-eslint/ban-ts-ignore': error
       '@typescript-eslint/ban-types': error

src/execution/execute.d.ts

@@ -34,7 +34,7 @@ export interface ExecutionContext {
   operation: OperationDefinitionNode;
   variableValues: { [key: string]: any };
   fieldResolver: GraphQLFieldResolver<any, any>;
-  errors: GraphQLError[];
+  errors: Array<GraphQLError>;
 }
 
 export interface ExecutionResultDataDefault {

src/language/visitor.d.ts

@@ -52,7 +52,7 @@ export type VisitFn<TAnyNode, TVisitedNode = TAnyNode> = (
 export type VisitorKeyMap<T> = { [P in keyof T]: ReadonlyArray<keyof T[P]> };
 
 // TODO: Should be `[]`, but that requires TypeScript@3
-type EmptyTuple = never[];
+type EmptyTuple = Array<never>;
 
 export const QueryDocumentKeys: {
   Name: EmptyTuple;

src/type/definition.d.ts

@@ -388,10 +388,10 @@ export class GraphQLObjectType<
   );
 
   getFields(): GraphQLFieldMap<any, TContext, TArgs>;
-  getInterfaces(): GraphQLInterfaceType[];
+  getInterfaces(): Array<GraphQLInterfaceType>;
 
   toConfig(): GraphQLObjectTypeConfig<any, any> & {
-    interfaces: GraphQLInterfaceType[];
+    interfaces: Array<GraphQLInterfaceType>;
     fields: GraphQLFieldConfigMap<any, any>;
     extensions: Maybe<Readonly<Record<string, any>>>;
     extensionASTNodes: ReadonlyArray<ObjectTypeExtensionNode>;
@@ -414,7 +414,7 @@ export interface GraphQLObjectTypeConfig<
 > {
   name: string;
   description?: Maybe<string>;
-  interfaces?: Thunk<Maybe<GraphQLInterfaceType[]>>;
+  interfaces?: Thunk<Maybe<Array<GraphQLInterfaceType>>>;
   fields: Thunk<GraphQLFieldConfigMap<TSource, TContext, TArgs>>;
   isTypeOf?: Maybe<GraphQLIsTypeOfFn<TSource, TContext>>;
   extensions?: Maybe<Readonly<Record<string, any>>>;
@@ -510,7 +510,7 @@ export interface GraphQLField<
   name: string;
   description: Maybe<string>;
   type: GraphQLOutputType;
-  args: GraphQLArgument[];
+  args: Array<GraphQLArgument>;
   resolve?: GraphQLFieldResolver<TSource, TContext, TArgs>;
   subscribe?: GraphQLFieldResolver<TSource, TContext, TArgs>;
   isDeprecated?: boolean;
@@ -567,10 +567,10 @@ export class GraphQLInterfaceType {
 
   constructor(config: Readonly<GraphQLInterfaceTypeConfig<any, any>>);
   getFields(): GraphQLFieldMap<any, any>;
-  getInterfaces(): GraphQLInterfaceType[];
+  getInterfaces(): Array<GraphQLInterfaceType>;
 
   toConfig(): GraphQLInterfaceTypeConfig<any, any> & {
-    interfaces: GraphQLInterfaceType[];
+    interfaces: Array<GraphQLInterfaceType>;
     fields: GraphQLFieldConfigMap<any, any>;
     extensions: Maybe<Readonly<Record<string, any>>>;
     extensionASTNodes: ReadonlyArray<InterfaceTypeExtensionNode>;
@@ -589,7 +589,7 @@ export interface GraphQLInterfaceTypeConfig<
 > {
   name: string;
   description?: Maybe<string>;
-  interfaces?: Thunk<Maybe<GraphQLInterfaceType[]>>;
+  interfaces?: Thunk<Maybe<Array<GraphQLInterfaceType>>>;
   fields: Thunk<GraphQLFieldConfigMap<TSource, TContext, TArgs>>;
   /**
    * Optionally provide a custom type resolver function. If one is not provided,
@@ -634,10 +634,10 @@ export class GraphQLUnionType {
   extensionASTNodes: Maybe<ReadonlyArray<UnionTypeExtensionNode>>;
 
   constructor(config: Readonly<GraphQLUnionTypeConfig<any, any>>);
-  getTypes(): GraphQLObjectType[];
+  getTypes(): Array<GraphQLObjectType>;
 
   toConfig(): GraphQLUnionTypeConfig<any, any> & {
-    types: GraphQLObjectType[];
+    types: Array<GraphQLObjectType>;
     extensions: Maybe<Readonly<Record<string, any>>>;
     extensionASTNodes: ReadonlyArray<UnionTypeExtensionNode>;
   };
@@ -650,7 +650,7 @@ export class GraphQLUnionType {
 export interface GraphQLUnionTypeConfig<TSource, TContext> {
   name: string;
   description?: Maybe<string>;
-  types: Thunk<GraphQLObjectType[]>;
+  types: Thunk<Array<GraphQLObjectType>>;
   /**
    * Optionally provide a custom type resolver function. If one is not provided,
    * the default implementation will call `isTypeOf` on each implementing
@@ -691,7 +691,7 @@ export class GraphQLEnumType {
   extensionASTNodes: Maybe<ReadonlyArray<EnumTypeExtensionNode>>;
 
   constructor(config: Readonly<GraphQLEnumTypeConfig>);
-  getValues(): GraphQLEnumValue[];
+  getValues(): Array<GraphQLEnumValue>;
   getValue(name: string): Maybe<GraphQLEnumValue>;
   serialize(value: any): Maybe<string>;
   parseValue(value: any): Maybe<any>;

src/type/directives.d.ts

@@ -17,9 +17,9 @@ export function assertDirective(directive: any): GraphQLDirective;
 export class GraphQLDirective {
   name: string;
   description: Maybe<string>;
-  locations: DirectiveLocationEnum[];
+  locations: Array<DirectiveLocationEnum>;
   isRepeatable: boolean;
-  args: GraphQLArgument[];
+  args: Array<GraphQLArgument>;
   extensions: Maybe<Readonly<Record<string, any>>>;
   astNode: Maybe<DirectiveDefinitionNode>;
 
@@ -39,7 +39,7 @@ export class GraphQLDirective {
 export interface GraphQLDirectiveConfig {
   name: string;
   description?: Maybe<string>;
-  locations: DirectiveLocationEnum[];
+  locations: Array<DirectiveLocationEnum>;
   args?: Maybe<GraphQLFieldConfigArgumentMap>;
   isRepeatable?: Maybe<boolean>;
   extensions?: Maybe<Readonly<Record<string, any>>>;

src/type/schema.d.ts

@@ -77,8 +77,8 @@ export class GraphQLSchema {
   getDirective(name: string): Maybe<GraphQLDirective>;
 
   toConfig(): GraphQLSchemaConfig & {
-    types: GraphQLNamedType[];
-    directives: GraphQLDirective[];
+    types: Array<GraphQLNamedType>;
+    directives: Array<GraphQLDirective>;
     extensions: Maybe<Readonly<Record<string, any>>>;
     extensionASTNodes: ReadonlyArray<SchemaExtensionNode>;
     assumeValid: boolean;
@@ -107,8 +107,8 @@ export interface GraphQLSchemaConfig extends GraphQLSchemaValidationOptions {
   query: Maybe<GraphQLObjectType>;
   mutation?: Maybe<GraphQLObjectType>;
   subscription?: Maybe<GraphQLObjectType>;
-  types?: Maybe<GraphQLNamedType[]>;
-  directives?: Maybe<GraphQLDirective[]>;
+  types?: Maybe<Array<GraphQLNamedType>>;
+  directives?: Maybe<Array<GraphQLDirective>>;
   extensions?: Maybe<Readonly<Record<string, any>>>;
   astNode?: Maybe<SchemaDefinitionNode>;
   extensionASTNodes?: Maybe<ReadonlyArray<SchemaExtensionNode>>;

src/utilities/findDeprecatedUsages.d.ts

@@ -10,4 +10,4 @@ import { GraphQLSchema } from '../type/schema';
 export function findDeprecatedUsages(
   schema: GraphQLSchema,
   ast: DocumentNode,
-): GraphQLError[];
+): Array<GraphQLError>;

src/validation/validate.d.ts

@@ -41,7 +41,7 @@ export function validateSDL(
   documentAST: DocumentNode,
   schemaToExtend?: Maybe<GraphQLSchema>,
   rules?: ReadonlyArray<SDLValidationRule>,
-): GraphQLError[];
+): Array<GraphQLError>;
 
 /**
  * Utility function which asserts a SDL document is valid by throwing an error