Skip to content

Commit 561f9f0

Browse files
committed
Lint GitHub Actions
Right now we pass NPM token in github action and plan to have automatic releases that is why it is critical to lint action files. I didn't find any JS-based solution and the only validator I could find is https://github.com/rhysd/actionlint
1 parent dae90de commit 561f9f0

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ jobs:
3131
- name: Spellcheck
3232
run: npm run check:spelling
3333

34+
- name: Lint GitHub Actions
35+
uses: docker://rhysd/actionlint:latest
36+
with:
37+
args: -color
38+
3439
checkForCommonlyIgnoredFiles:
3540
name: Check for commonly ignored files
3641
runs-on: ubuntu-latest

.github/workflows/cmd-publish-pr-on-npm.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ on:
33
workflow_call:
44
inputs:
55
pullRequestJSON:
6+
description: String that contain JSON payload for `pull_request` event.
67
required: true
78
type: string
89
secrets:
910
NPM_CANARY_PR_PUBLISH_TOKEN:
11+
description: NPM token to publish canary release.
1012
required: true
1113
jobs:
1214
build-npm-dist:

.github/workflows/cmd-run-benchmark.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ on:
33
workflow_call:
44
inputs:
55
pullRequestJSON:
6+
description: String that contain JSON payload for `pull_request` event.
67
required: true
78
type: string
89
jobs:
@@ -19,7 +20,7 @@ jobs:
1920
- name: Deepen cloned repo
2021
env:
2122
BASE_SHA: ${{ fromJSON(inputs.pullRequestJSON).base.sha }}
22-
run: 'git fetch --depth=1 origin $BASE_SHA:refs/tags/BASE'
23+
run: 'git fetch --depth=1 origin "$BASE_SHA:refs/tags/BASE"'
2324

2425
- name: Setup Node.js
2526
uses: actions/setup-node@v2

.github/workflows/deploy-artifact-as-branch.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,19 @@ on:
33
workflow_call:
44
inputs:
55
environment:
6+
description: Environment to publish under
67
required: true
78
type: string
89
artifact_name:
10+
description: Artifact name
911
required: true
1012
type: string
1113
target_branch:
14+
description: Target branch
1215
required: true
1316
type: string
1417
commit_message:
18+
description: Commit message
1519
required: true
1620
type: string
1721
jobs:

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Deepen cloned repo
1717
env:
1818
BASE_SHA: ${{ github.event.pull_request.base.sha }}
19-
run: 'git fetch --depth=1 origin $BASE_SHA:refs/tags/BASE'
19+
run: 'git fetch --depth=1 origin "$BASE_SHA:refs/tags/BASE"'
2020

2121
- name: Setup Node.js
2222
uses: actions/setup-node@v2

0 commit comments

Comments
 (0)