-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[language-service] getRange does not work for line 0 #3168
Comments
#3149 I believe will fix this? |
would you say this is a duplicate of #2874? |
Also this part
tells me that the issue is in this function, since invariant expects 0 based line index. Yet it does not work when there is just line 0:
|
hmm, indeed. if I understand correctly, i think this is why we had to offset lines in have you seen this surface as an issue in any specific implementation such as graphiql or monaco-graphql or the LSP server, or are you making a new implementation directly from |
I am using this with monaco
As you see the actual query is just 1 liner (incomplete) = "query { }" |
Seems there is a bug here:
The call comes in from doHover(..) if its called on the 1st line - it comes in as line 0. So the for loop never triggers and an invariant error is thrown.
The text was updated successfully, but these errors were encountered: