Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept explicit null input values in queries #26

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Accept explicit null input values in queries #26

merged 1 commit into from
Feb 4, 2017

Conversation

zaeleus
Copy link
Contributor

@zaeleus zaeleus commented Jan 27, 2017

Explicit null values are valid for nullable input values. See
https://facebook.github.io/graphql/#sec-Types.Non-Null.

Fixes #23

Explicit `null` values are valid for nullable input values. See
<https://facebook.github.io/graphql/#sec-Types.Non-Null>.

Fixes #23
@mhallin
Copy link
Member

mhallin commented Jan 27, 2017

Nice!

This is probably part of an effort to support the "October 2016" GraphQL specification (https://github.com/facebook/graphql/releases/tag/October2016) where the null literal was introduced. I wonder if we're still compatible with the revised/clarified execution rules as outlined in graphql/graphql-spec#221 - I haven't read that in detail yet.

@mhallin mhallin merged commit 40cc76d into graphql-rust:master Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants