Fix warnings in tests

Author: tyranron

.github/workflows/ci.yml

@@ -240,6 +240,8 @@ jobs:
       - run: make test.cargo crate=${{ matrix.crate }}
                   careful=${{ (matrix.toolchain == 'nightly' && 'yes')
                            ||                                   'no' }}
+        env:
+          RUSTFLAGS: -D warnings
 
   test-book:
     name: test (Book)

benches/src/lib.rs

@@ -1,8 +1,4 @@
-#[cfg(test)]
-mod for_benches_only {
-    use criterion as _;
-    use tokio as _;
-}
+#![cfg_attr(test, expect(unused_crate_dependencies, reason = "benches"))]
 
 use juniper::{
     DefaultScalarValue, EmptyMutation, EmptySubscription, ExecutionError, FieldError, GraphQLEnum,

juniper_actix/examples/subscription.rs

@@ -1,5 +1,7 @@
 //! This example demonstrates asynchronous subscriptions with [`actix_web`].
 
+#![expect(unused_crate_dependencies, reason = "example")]
+
 use std::{pin::Pin, time::Duration};
 
 use actix_cors::Cors;

juniper_actix/src/lib.rs

@@ -1,6 +1,7 @@
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
+#![cfg_attr(test, expect(unused_crate_dependencies, reason = "examples"))]
 
 use actix_web::{
     Error, FromRequest, HttpMessage, HttpRequest, HttpResponse, error::JsonPayloadError,
@@ -855,6 +856,7 @@ mod subscription_tests {
         (HttpRequest, web::Payload, web::Data<Schema>),
         Output = Result<HttpResponse, Error>,
     > {
+        #[expect(closure_returning_async_block, reason = "not possible")]
         move |req: HttpRequest, stream: web::Payload, schema: web::Data<Schema>| async move {
             let context = Database::new();
             let schema = schema.into_inner();

juniper_axum/examples/custom.rs

@@ -3,6 +3,8 @@
 //! [`Handler`]: axum::handler::Handler
 //! [`starwars::schema`]: juniper::tests::fixtures::starwars::schema
 
+#![expect(unused_crate_dependencies, reason = "example")]
+
 use std::{net::SocketAddr, sync::Arc};
 
 use axum::{
@@ -31,7 +33,7 @@ async fn homepage() -> Html<&'static str> {
         .into()
 }
 
-pub async fn custom_subscriptions(
+async fn custom_subscriptions(
     Extension(schema): Extension<Arc<Schema>>,
     Extension(database): Extension<Database>,
     ws: WebSocketUpgrade,

juniper_axum/examples/simple.rs

@@ -1,5 +1,7 @@
 //! This example demonstrates simple default integration with [`axum`].
 
+#![expect(unused_crate_dependencies, reason = "example")]
+
 use std::{net::SocketAddr, sync::Arc, time::Duration};
 
 use axum::{
@@ -15,7 +17,7 @@ use tokio::{net::TcpListener, time::interval};
 use tokio_stream::wrappers::IntervalStream;
 
 #[derive(Clone, Copy, Debug)]
-pub struct Query;
+struct Query;
 
 #[graphql_object]
 impl Query {
@@ -26,7 +28,7 @@ impl Query {
 }
 
 #[derive(Clone, Copy, Debug)]
-pub struct Subscription;
+struct Subscription;
 
 type NumberStream = BoxStream<'static, Result<i32, FieldError>>;
 

juniper_axum/src/lib.rs

@@ -1,6 +1,10 @@
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
+#![cfg_attr(
+    test,
+    expect(unused_crate_dependencies, reason = "examples and integration tests")
+)]
 
 // TODO: Try remove on upgrade of `axum` crate.
 mod for_minimal_versions_check_only {

juniper_axum/tests/http_test_suite.rs

@@ -1,3 +1,7 @@
+//! [`HttpIntegration`] testing for [`axum`].
+
+#![expect(unused_crate_dependencies, reason = "integration tests")]
+
 use std::sync::Arc;
 
 use axum::{

juniper_axum/tests/ws_test_suite.rs

@@ -1,4 +1,7 @@
+//! [`WsIntegration`] testing for [`axum`].
+
 #![cfg(not(windows))]
+#![expect(unused_crate_dependencies, reason = "integration tests")]
 
 use std::{net::SocketAddr, sync::Arc};
 

juniper_codegen/src/lib.rs

@@ -1,6 +1,10 @@
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
 #![recursion_limit = "1024"]
+#![cfg_attr(
+    all(test, not(doctest)),
+    expect(unused_crate_dependencies, reason = "for doc tests only")
+)]
 
 // NOTICE: Unfortunately this macro MUST be defined here, in the crate's root module, because Rust
 //         doesn't allow to export `macro_rules!` macros from a `proc-macro` crate type currently,

juniper_graphql_ws/src/graphql_transport_ws/mod.rs

@@ -823,7 +823,7 @@ mod test {
 
     #[tokio::test]
     async fn test_init_params_ok() {
-        let mut conn = Connection::new(new_test_schema(), |params: Variables| async move {
+        let mut conn = Connection::new(new_test_schema(), async |params: Variables| {
             assert_eq!(params.get("foo"), Some(&graphql_input_value!("bar")));
             Ok(ConnectionConfig::new(Context(1))) as Result<_, Infallible>
         });
@@ -842,7 +842,7 @@ mod test {
 
     #[tokio::test]
     async fn test_init_params_error() {
-        let mut conn = Connection::new(new_test_schema(), |params: Variables| async move {
+        let mut conn = Connection::new(new_test_schema(), async |params: Variables| {
             assert_eq!(params.get("foo"), Some(&graphql_input_value!("bar")));
             Err(io::Error::new(io::ErrorKind::Other, "init error"))
         });

juniper_graphql_ws/src/graphql_ws/mod.rs

@@ -720,7 +720,7 @@ mod test {
 
     #[tokio::test]
     async fn test_init_params_ok() {
-        let mut conn = Connection::new(new_test_schema(), |params: Variables| async move {
+        let mut conn = Connection::new(new_test_schema(), async |params: Variables| {
             assert_eq!(params.get("foo"), Some(&graphql_input_value!("bar")));
             Ok(ConnectionConfig::new(Context(1))) as Result<_, Infallible>
         });
@@ -736,7 +736,7 @@ mod test {
 
     #[tokio::test]
     async fn test_init_params_error() {
-        let mut conn = Connection::new(new_test_schema(), |params: Variables| async move {
+        let mut conn = Connection::new(new_test_schema(), async |params: Variables| {
             assert_eq!(params.get("foo"), Some(&graphql_input_value!("bar")));
             Err(io::Error::new(io::ErrorKind::Other, "init error"))
         });

juniper_hyper/examples/hyper_server.rs

@@ -1,3 +1,7 @@
+//! This example demonstrates a simple [`hyper`] server implementation for [`juniper`].
+
+#![expect(unused_crate_dependencies, reason = "example")]
+
 use std::{convert::Infallible, error::Error, net::SocketAddr, sync::Arc};
 
 use hyper::{Method, Response, StatusCode, server::conn::http1, service::service_fn};

juniper_hyper/src/lib.rs

@@ -1,5 +1,6 @@
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
+#![cfg_attr(test, expect(unused_crate_dependencies, reason = "examples"))]
 
 use std::{error::Error, fmt, string::FromUtf8Error, sync::Arc};
 

juniper_rocket/examples/simple.rs

@@ -1,6 +1,6 @@
 //! Example demonstrating all possible HTTP endpoints integration for [`rocket`].
 
-#![expect(unused_crate_dependencies, reason = "single example")]
+#![expect(unused_crate_dependencies, reason = "example")]
 
 use juniper::{
     EmptyMutation, EmptySubscription, RootNode,

juniper_subscriptions/examples/basic.rs

@@ -1,3 +1,5 @@
+//! This example demonstrates how to use a [`Coordinator`] for executing a GraphQL subscription.
+
 use std::pin::Pin;
 
 use futures::{Stream, StreamExt};
@@ -8,7 +10,7 @@ use juniper::{
 use juniper_subscriptions::Coordinator;
 
 #[derive(Clone)]
-pub struct Database;
+struct Database;
 
 impl juniper::Context for Database {}
 
@@ -18,7 +20,7 @@ impl Database {
     }
 }
 
-pub struct Query;
+struct Query;
 
 #[graphql_object(context = Database)]
 impl Query {
@@ -27,7 +29,7 @@ impl Query {
     }
 }
 
-pub struct Subscription;
+struct Subscription;
 
 type StringStream = Pin<Box<dyn Stream<Item = Result<String, FieldError>> + Send>>;
 

juniper_warp/examples/subscription.rs

@@ -1,5 +1,7 @@
 //! This example demonstrates asynchronous subscriptions with [`warp`].
 
+#![expect(unused_crate_dependencies, reason = "example")]
+
 use std::{pin::Pin, sync::Arc, time::Duration};
 
 use futures::Stream;

juniper_warp/src/lib.rs

@@ -1,7 +1,10 @@
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![deny(missing_docs)]
+#![cfg_attr(
+    test,
+    expect(unused_crate_dependencies, reason = "examples and integration tests")
+)]
 
 // TODO: Try remove on upgrade of `warp` crate.
 mod for_minimal_versions_check_only {
@@ -532,7 +535,7 @@ mod tests {
 
             let filter = warp::path("graphql")
                 .and(make_graphql_filter(schema, context_extractor))
-                .recover(|rejection: warp::reject::Rejection| async move {
+                .recover(async |rejection: warp::reject::Rejection| {
                     rejection
                         .find::<ExtractionError>()
                         .map(|e| e.into_response())

juniper_warp/tests/http_test_suite.rs

@@ -1,3 +1,7 @@
+//! [`HttpIntegration`] testing for [`warp`].
+
+#![expect(unused_crate_dependencies, reason = "integration tests")]
+
 use futures::TryStreamExt as _;
 use itertools::Itertools as _;
 use juniper::{