Error handling more closely as graphql-js #60
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
original_error
attribute as per graphql-js and now raising theGraphQLError
with the previous stack as that what it seems the js code is intending.I haven't tested yet if that works in the actual app so I am not entirely sure this will work given that we do this
ctx.errors.append(e)
. In py3 it seems there is a__traceback__
on anyException
but not in py2. So I wouldn't even be sure how to best handle it cross-version otherwise.Anyway, this is my first go at this implementation, might revise when I actually get to test it out etc.