Add py.typed file to allow users to use the types this library provides #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cito
reviewed
Dec 10, 2019
|
Ah, thanks @Cito . Added! |
ckarnell
force-pushed
the
allow-use-of-typing
branch
from
e0d774d to
6e1104e
Compare
ckarnell
force-pushed
the
allow-use-of-typing
branch
from
6e1104e to
743f847
Compare
|
@Cito I added the required change and now tests seem to be failing, but not the same ones. Their output is a little hard to read, is there any chance you can help me understand? |
|
@ckarnell. Tanks for the change. I have restarted the failing tests and their are green now. Looks like this is caused by dict sort order which is random in Py 2.7 and 3.4 where the tests were failing. This needs to be fixed independently if it happens again. |
Cito
approved these changes
Dec 11, 2019
|
@Cito Got it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was generating type stubs for this library and noticed it already has some decent typing! This PR adds a py.typed file to the library, allowing consumers to use the types for type checking their own projects.