Consistently translate Python enumerations to values #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbruun
changed the title
…ython enumeraiton as the value type.
nikordaris
approved these changes
Jul 19, 2019
jkimbo
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thank you very much for the hard work on this. It's very appreciated!
We use Python enumeration values as the internally represented value for our GraphQL enumerations for a number of reasons. The recent change of coercing Python enumeration values to their internal values before lookup in
GraphQLEnumType.serializemeans that 2.1.0 broke the ability to do this.This should fix the issue by forcing the same value-ification in the lookup dictionary to make it consistent.