Skip to content

Path fix #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Path fix #186

merged 2 commits into from
Jun 5, 2018

Conversation

syrusakbary
Copy link
Member

This PR improves the path resolution in two ways:

  • resolve_info.path doesn't get modified on item lists (specially important when resolving async/in paralell)
  • GraphQLError can have a path attached that will show when serialized

@syrusakbary
Copy link
Member Author

This PR fixes #127 #60

@syrusakbary syrusakbary merged commit 490d056 into master Jun 5, 2018
@ProjectCheshire ProjectCheshire deleted the path-fix branch June 2, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant