Update enum tests #163
Merged
Update enum tests #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Mar 14, 2018
graphql/type/definition.py
Outdated
| @@ -406,6 +406,12 @@ def __init__(self, name, values, description=None): | |||
|
|
|||
| self.values = define_enum_values(self, values) | |||
|
|
|||
| def getValues(self): | |||
There was a problem hiding this comment.
We should name this get_values (camel case)
syrusakbary
reviewed
Mar 14, 2018
graphql/type/definition.py
Outdated
| def getValues(self): | ||
| return self.values | ||
|
|
||
| def getValue(self, name): |
|
I will happily merge the PR once the functions are renamed to |
|
@syrusakbary done! |
|
@syrusakbary this should be ready to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update enum tests to bring them inline with graphql-js v0.13.1
I've not included the complex value tests since I'm not sure how it can be achieved in Python.