-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy NaN handling #852
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still happening, is there any particular reason for resolving np.nan with NaN in type Float? I think a json compliant solution (null as @zifeo suggested) should be supported. |
Still an issue |
@zifeo if you would like to create a PR with a custom scalar for Numpy I will happily merge it. Unfortunately I don't have the time to work on this at the moment. |
@jkimbo not sure when I will have the time yet, however can you reopen the issue? |
Yep |
This is an issue AFAIK for all special float values (not really numpy specific) |
Currently when a
[Float]
type resolves tonp.array([1, np.nan])
the generated payload is[1, NaN]
which is not json-compilant (rather thannull
) without any warning. A custom scalar can do the job however as numpy is so widely used, maybe this should be supported out of the box?The text was updated successfully, but these errors were encountered: