Skip to content

Refactor converters, improve union and connection field handling, and add Python 3.13–3.14 support #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Refactor converters, improve union and connection field handling, and add Python 3.13–3.14 support #245

wants to merge 15 commits into from

Conversation

@abhinand-c
Copy link
Contributor

Enhancements

  • Field descriptions: Added support for setting field descriptions using the description="..." argument.
  • Python version support: Added compatibility and CI testing for Python 3.13 and 3.14.

Fixes

  • Corrected handling of fields with required=True and null=True defaults.
  • Fixed errors in:
    • convert_field_to_list resolver
    • get_queried_union_types for union fragments
    • Connection filter generation for forward/backward relations
    • Union type resolution issues in nested usage
    • ConnectionField count queries to prioritize pk__in filters
  • Excluded test modules from package builds.
  • Updated dependency versions for compatibility.

Refactors

  • Modularized converter.py by moving resolver logic into separate modules for better maintainability.
  • Simplified resolver flow using a unified get_field_resolver utility.

mak626 and others added 15 commits October 23, 2025 11:43
@mak626
fix: fields having required=true and null=true were being set as set …
ddd0f79 
…as required in graphql layer
@mak626
fix: package version in __init__.py
7b3bd08
@mak626
feat: field's description can be set by adding description="..." argu…
fb7a4bd 
…ment in field similar to graphql
@mak626
fix[converter]: convert_field_to_list resolver error
9a594fe 
new get_query_fields cannot find union types called. Introduced get_queried_union_types to find it
@mak626
bump: dependencies
08295c6 
graphene: 3.4.3
graphql-core: 3.2.5
pymongo: 4.10.1
mongoengine: 0.29.1
@mak626
fix[union-converter]: get_queried_union_types can now handle union fr…
1231952 
…agments
@mak626
fix[connection-filter]: connection filter generation error for the fo…
ff700b3 
…llowing types is fixed.

ListField(EmbeddedDocumentListField(...))
ListField(GenericEmbeddedDocumentField(...))
ListField(GenericLazyReferenceField(...))
@mak626
fix[union-type]: union type resolution caused errors when using
b6b1ad6 
fragment spread inside a UnionType
@mak626
fix[union-type]: union type resolution caused errors when using
f29063d 
fragment spread syntax for GenericReferenceField
@mak626
refact: converter.py resolver code using get_field_resolver
07101f6
@mak626
refact: converter.py resolver code by separating resolvers to separat…
cc4bbac 
…e classes
@mak626
fix: exclude tests from package build
75938db
@abhinand-c
fix(ConnectionField): Priorities pk__in filter for finding count of n…
a93c58e 
…ested connection field
@abhinand-c
fix(tests): Run tests on PR, and add support for 3.13, 3.14
33f5afa
@abhinand-c
Merge pull request #22 from strollby/fix/nested-connectionfield
f4bbbd0 
Fix Issue of ConnectionField unnecessarily counting whole collection instead of subset
@abhinand-c
Copy link
Contributor Author

@mak626 Please review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhinand-c @mak626