Skip to content

Bump graphene from 3.0b7 to 3.0 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Lwackp
Copy link

@Lwackp Lwackp commented Jan 17, 2022

No description provided.

@Lwackp Lwackp mentioned this pull request Jan 17, 2022
Copy link
Collaborator

@blochs blochs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK

@abawchen
Copy link
Collaborator

@arunsureshkumar : do you have time to take a look? thanks.

@blochs
Copy link
Collaborator

blochs commented Jan 18, 2022

Just a quick note, there are still other graphql-python related code items without these dependencies upgraded that can cause issues with dependency resolution (ie graphene-sqlalchemy)

@blochs
Copy link
Collaborator

blochs commented Jan 18, 2022

Also one more item, the graphene version for dev purposes is actually 3.0.0b7 NOT 3.0b7 @abawchen

https://github.com/graphql-python/graphene/releases/tag/v3.0.0b7

@Lwackp
Copy link
Author

Lwackp commented Jan 20, 2022

@abawchen @arunsureshkumar any chance we can merge this soon?

@blochs
Copy link
Collaborator

blochs commented Feb 1, 2022

@abawchen @arunsureshkumar Any chance we can resolve this?

@arunsureshkumar
Copy link
Collaborator

arunsureshkumar commented Feb 1, 2022 via email

@ddelange
Copy link

duplicate of #191

@abhinand-c
Copy link
Contributor

@arunsureshkumar Since the dependency has been updated in #202 and #191 , we can close this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants