Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 #904

Merged
merged 8 commits into from
Apr 6, 2020
Merged

Python 3 #904

merged 8 commits into from
Apr 6, 2020

Conversation

ulgens
Copy link
Collaborator

@ulgens ulgens commented Mar 14, 2020

Almost all of these changes were included in Graphene 3 related pull requests but they were waiting there for a long time.

Changes:

  • Remove Python 2 support
  • Remove support for deprecated Django versions: 2.0, 2.1
  • Remove support for django-filter < 2
  • Add support for Python 3.8
  • Resolve RemovedInDjango40Warning warnings

@ulgens ulgens mentioned this pull request Mar 15, 2020
* Remove unsupported Django versions
* Remove unsupported Python versions
* Add Python 3.8
* gql/graphene-django/graphene_django/tests/test_converter.py:175:
RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is
deprecated in favor of django.utils.translation.gettext_lazy().

* graphene-django/graphene_django/utils/utils.py:28:
RemovedInDjango40Warning: force_text() is deprecated in favor of
force_str().
singledispatch is inluded with Python >= 3.4, no need for external
package.
@ulgens
Copy link
Collaborator Author

ulgens commented Mar 21, 2020

@jkimbo Any chance to look at this one?

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great thanks @ulgens ! I'm going to hold off merging for a bit just so that we can try and get graphene 3 over the line and then we can release all of this as graphene-django v3

@jkimbo jkimbo mentioned this pull request Apr 6, 2020
7 tasks
@rhizoome rhizoome mentioned this pull request Apr 6, 2020
@jkimbo jkimbo changed the base branch from master to v3 April 6, 2020 12:20
@jkimbo jkimbo merged commit dd0d6ef into graphql-python:v3 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants