Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff in pre-commit #1441

Merged
merged 15 commits into from
Aug 5, 2023
Merged

Use ruff in pre-commit #1441

merged 15 commits into from
Aug 5, 2023

Conversation

kiendang
Copy link
Collaborator

@kiendang kiendang commented Aug 5, 2023

No description provided.

@kiendang kiendang force-pushed the ruff-pre-commit branch 3 times, most recently from 10e26b9 to 49e10dc Compare August 5, 2023 11:31
sjdemartini
sjdemartini reviewed Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for doing this! Overall this LGTM!

.ruff.toml Show resolved Hide resolved
.ruff.toml Show resolved Hide resolved
.ruff.toml Show resolved Hide resolved
graphene_django/filter/utils.py Outdated Show resolved Hide resolved
graphene_django/forms/tests/test_mutation.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@kiendang kiendang mentioned this pull request Aug 5, 2023
Merged
@firaskafri firaskafri merged commit 9a773b9 into main Aug 5, 2023
24 checks passed
@firaskafri firaskafri deleted the ruff-pre-commit branch August 5, 2023 22:47
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 9, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
c3a0cf1 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
246e024 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
80294b4 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
9445e84 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
1d6e084 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 10, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
b846c37 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 11, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
3d4bc35 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 11, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
0a8d0da 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 11, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
2cbdbc9 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 11, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
b6e0e02 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Aug 11, 2023
@kiendang @superlevure
Use ruff in pre-commit (graphql-python#1441)
e94be2f 
* Use ruff in pre-commit

* Add pyupgrade

* Add isort

* Add bugbear

* Fix B015 Pointless comparison

* Fix B026

* B018 false positive

* Remove flake8 and isort config from setup.cfg

* Remove black and flake8 from dev dependencies

* Update black

* Show list of fixes applied with autofix on

* Fix typo

* Add C4 flake8-comprehensions

* Add ruff to dev dependencies

* Fix up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjdemartini sjdemartini sjdemartini approved these changes

@firaskafri firaskafri Awaiting requested review from firaskafri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiendang @sjdemartini @firaskafri