Add JSONField back to graphene_django.compat module for backwards compatibility #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1428 This should improve backwards compatibility, fixing issues in downstream packages (notably graphene-django-cud tOgg1/graphene-django-cud#109, and also graphene-django-extras, both of which depended on `graphene_django.compat.JSONField`).
kiendang
approved these changes
Jul 9, 2023
|
@firaskafri any chance you could take a look and see about merging this? Just a one-line change to fix backwards incompatibility. This is blocking my team from upgrading past 3.1.1 (and seemingly others like #1428). Thanks! |
firaskafri
approved these changes
Jul 18, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
) Fixes graphql-python#1428 This should improve backwards compatibility, fixing issues in downstream packages (notably graphene-django-cud tOgg1/graphene-django-cud#109, and also graphene-django-extras, both of which depended on `graphene_django.compat.JSONField`). Co-authored-by: Steven DeMartini <sjdemartini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428 (after the change merged in #1421)
This should improve backwards compatibility, fixing issues in downstream packages (notably graphene-django-cud
tOgg1/graphene-django-cud#109, and also graphene-django-extras, both of which depended on
graphene_django.compat.JSONField). I've tested this in my downstream project and confirmed it resolved issues in both of those packages.