Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Django 4.1 compatibility fixes to v2 #1413

Merged
merged 8 commits into from
May 26, 2023

Conversation

santiagoaguiar
Copy link

@santiagoaguiar santiagoaguiar commented May 25, 2023

This backports e584d5e to v2 to be used with Django 4.1.

Hoping we can get this to a 2.16 release 🙏 .

Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the status of graphene-django v2, but the changes here LGTM

@santiagoaguiar
Copy link
Author

santiagoaguiar commented May 26, 2023

Any thoughts on why the build could be failing? Doesn't seem to be related to my changes, I think?

@kiendang
Copy link
Collaborator

kiendang commented May 26, 2023

@santiagoaguiar just needed to backport a bunch of test and CI updates as well. all settled now.

@firaskafri firaskafri merged commit 7c780a9 into graphql-python:v2 May 26, 2023
@firaskafri
Copy link
Collaborator

@santiagoaguiar Just released v2.16.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants