Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum support to filters and fix filter typing (v2) #1114

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

tcleonard
Copy link
Collaborator

  • Add filtering support for choice fields converted to graphql Enum (or not)
  • Fix type of various filters (used to default to String)
  • Fix bug with contains introduced in previous PR
  • Fix bug with declared filters being overridden (see PR Only override non declared filters  #1108)
  • Fix support for ArrayField and add documentation
    103427653-58ec3a80-4b77-11eb-9543-775c9c208dbd

Thomas Leonard added 2 commits February 13, 2021 11:30
…or not)

- Fix type of various filters (used to default to String)
- Fix bug with contains introduced in previous PR
- Fix bug with declared filters being overridden (see PR graphql-python#1108)
- Fix support for ArrayField and add documentation
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zbyte64 zbyte64 merged commit e323e2b into graphql-python:v2 Feb 23, 2021
@lucas-bremond
Copy link
Contributor

\o/ \o/ \o/

@superlevure superlevure deleted the enum-filtering-v2 branch October 20, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants