Why DjangoFormMutation.perform_mutate() calls form.save()

[ruohola]

Django's plain (non-model) Forms don't have the save() method. Why does DjangoFormMutation.perform_mutate() still call that here:

graphene-django/graphene_django/forms/mutation.py

Line 104 in 3058118

form.save()

Am I missing something or does this just always end up in an error?

[zbyte64]

You're correct. That should probably be part of the DjangoModelFormMutation instead

[ruohola]

You're correct. That should probably be part of the DjangoModelFormMutation instead

Yeah, it is there:

graphene-django/graphene_django/forms/mutation.py

Lines 179 to 183 in 3058118

	@classmethod
	def perform_mutate(cls, form, info):
	obj = form.save()
	kwargs = {cls._meta.return_field_name: obj}
	return cls(errors=[], **kwargs)

and I think it should only be there.

[ruohola]

Made a PR for this, @zbyte64 could you review?