Make AsyncTransport and Transport proper abstract base classes
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@abc.abstractmethod` decorator requires that the class’s metaclass be `abc.ABCMeta` or derived from it. Usually this is satisfied by inherit from `abc.ABC`. See: https://docs.python.org/3/library/abc.html#abc.abstractmethod
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2243 2243
=========================================
Hits 2243 2243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks, Well spotted! |
Make `Transport` inherit from `abc.ABC`.
willfrey
changed the title
AsyncTransport a proper abstract base classAsyncTransport and Transport proper abstract base classes
leszekhanusz
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@abc.abstractmethoddecorator requires that the class’s metaclass beabc.ABCMetaor derived from it. Usually this is satisfied by inherit fromabc.ABC.See: https://docs.python.org/3/library/abc.html#abc.abstractmethod