Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump graphql-core to 3.2.0 #283

Conversation

leszekhanusz
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #283 (1de3c31) into master (5440c6c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2060      2060           
=========================================
  Hits          2060      2060           
Impacted Files Coverage Δ
gql/dsl.py 100.00% <100.00%> (ø)
gql/utilities/build_client_schema.py 100.00% <100.00%> (ø)
gql/utilities/get_introspection_query_ast.py 100.00% <100.00%> (ø)
gql/utilities/parse_result.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5440c6c...1de3c31. Read the comment docs.

@leszekhanusz
Copy link
Collaborator Author

@Cito
Should I release the stable 3.0.0 version of gql with graphql-core 3.1.x or should I wait for graphql-core 3.2 stable and merge this PR? What do you think?

@Cito
Copy link
Member

Cito commented Dec 13, 2021

If everything is working fine with the 3.2 rc3 version, then I think it's ok - 3,2 final will be released soon and will not have breaking changes.

leszekhanusz and others added 2 commits December 21, 2021 16:13
This new version of GraphQL-core replaces the FrozenLists in AST nodes
with tuples, so we need to make the appropriate changes in dsl.py.
@Cito
Copy link
Member

Cito commented Dec 29, 2021

Sorry, there was a 3.2 rc4 version, and contrary to what I promised above, it contained one breaking change. To make up for this, I have already updated this PR with the necessary fixes. And this should really be the last breaking change before 3.2 final.

@leszekhanusz
Copy link
Collaborator Author

No worries, keep up the good work!

@leszekhanusz leszekhanusz merged commit bf16f1e into graphql-python:master Jan 16, 2022
@leszekhanusz leszekhanusz deleted the fix_graphql_core_3_2_0_compatibility branch March 12, 2022 12:41
@ddelange
Copy link

ddelange commented Apr 4, 2022

Does this PR drop support for graphql-core==3.1.*? Or could gql theoretically still allow 3.1.* in install_requires? Doing so would solve dephell ref graphql-python/graphene#1406

Edit: I asked too soon, looks from comments above it is definitely breaking 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants