Fix running execute and subscribe of client in a new Thread #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a new Thread, there is no default asyncio event loop like the main thread And if we do asyncio.get_event_loop() OR if we create an asyncio.Event() Then a RuntimeError will be generated
|
That was a fast pull request, I will review this night :) |
KingDarBoja
added
status: waiting for reviewer
KingDarBoja
approved these changes
Aug 29, 2020
KingDarBoja
removed
the
status: waiting for reviewer
leszekhanusz
added a commit
to leruaa/gql
that referenced
this pull request
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a new Thread, there is no default asyncio event loop like the main thread
And if we do asyncio.get_event_loop() OR if we create an asyncio.Event()
Then a RuntimeError will be generated
This commit fixes this problem.
This should fix the issue #134 and allow to use gql inside Flask which is multiThreaded