Skip to content

Commit

Permalink
Bump graphql-core min version to 3.3.0a3 and remove await before subs…
Browse files Browse the repository at this point in the history
…cribe (#417)
  • Loading branch information
leszekhanusz authored Jun 5, 2023
1 parent d140b83 commit 66a1c3c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion gql/transport/local_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async def subscribe(
The results are sent as an ExecutionResult object
"""

subscribe_result = await subscribe(self.schema, document, *args, **kwargs)
subscribe_result = subscribe(self.schema, document, *args, **kwargs)

if isinstance(subscribe_result, ExecutionResult):
yield subscribe_result
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

install_requires = [
"graphql-core>=3.3.0a2,<3.4",
"graphql-core>=3.3.0a3,<3.4",
"yarl>=1.6,<2.0",
"backoff>=1.11.1,<3.0",
]
Expand Down
2 changes: 1 addition & 1 deletion tests/starwars/test_subscription.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ async def test_subscription_support():
params = {"ep": "JEDI"}
expected = [{**review, "episode": "JEDI"} for review in reviews[6]]

ai = await subscribe(StarWarsSchema, subs, variable_values=params)
ai = subscribe(StarWarsSchema, subs, variable_values=params)

result = [result.data["reviewAdded"] async for result in ai]

Expand Down

0 comments on commit 66a1c3c

Please sign in to comment.