Shutdown executor and provide new endpoint constructor #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into different issues when trying to use GraphQLWebsocketServlet within an OSGi container :
The first issue (which should also happen in any container) is about the executor started in ApolloSubscriptionKeepAliveRunner, which is never shut down, preventing the JVM to correctly quit. I've added shutdown callbacks in SubscriptionProtocolFactory / ApolloSubscriptionConnectionListener / ApolloSubscriptionKeepAliveRunner
Second issue is the GraphQLWebsocketServlet initialization - there's no way to pass explicit SubscriptionProtocolFactory, and prevent the creation of default instances, which was required in our case.