Merge pull request #180 from sammyhk/provide-ability-to-plug-in-pre-configured-objectmapper

Provide ability to plug in pre configured objectmapper

Author: oliemansm

src/main/java/graphql/servlet/ConfiguringObjectMapperProvider.java

@@ -1,28 +1,34 @@
 package graphql.servlet;
 
-import com.fasterxml.jackson.databind.InjectableValues;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.SerializationFeature;
-import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 
 public class ConfiguringObjectMapperProvider implements ObjectMapperProvider {
 
+  private final ObjectMapper objectMapperTemplate;
+
   private final ObjectMapperConfigurer objectMapperConfigurer;
 
+  public ConfiguringObjectMapperProvider(ObjectMapper objectMapperTemplate, ObjectMapperConfigurer objectMapperConfigurer) {
+    this.objectMapperTemplate = objectMapperTemplate == null ? new ObjectMapper() : objectMapperTemplate;
+    this.objectMapperConfigurer = objectMapperConfigurer == null ? new DefaultObjectMapperConfigurer() : objectMapperConfigurer;
+  }
+
+  public ConfiguringObjectMapperProvider(ObjectMapper objectMapperTemplate) {
+      this(objectMapperTemplate, null);
+  }
+
   public ConfiguringObjectMapperProvider(ObjectMapperConfigurer objectMapperConfigurer) {
-    this.objectMapperConfigurer = objectMapperConfigurer;
+    this(null, objectMapperConfigurer);
   }
 
   public ConfiguringObjectMapperProvider() {
-    this.objectMapperConfigurer = new DefaultObjectMapperConfigurer();
+    this(null, null);
   }
 
   @Override
   public ObjectMapper provide() {
-    ObjectMapper mapper = new ObjectMapper().disable(
-      SerializationFeature.FAIL_ON_EMPTY_BEANS).registerModule(new Jdk8Module());
-    objectMapperConfigurer.configure(mapper);
-
+    ObjectMapper mapper = this.objectMapperTemplate.copy();
+    this.objectMapperConfigurer.configure(mapper);
     return mapper;
   }
 }

src/main/java/graphql/servlet/DefaultObjectMapperConfigurer.java

@@ -1,13 +1,20 @@
 package graphql.servlet;
 
+import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 
 /**
  * @author Andrew Potter
  */
 public class DefaultObjectMapperConfigurer implements ObjectMapperConfigurer {
+
     @Override
     public void configure(ObjectMapper mapper) {
-
+        // default configuration for GraphQL Java Servlet
+        mapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
+        mapper.registerModule(new Jdk8Module());
+        mapper.setDefaultPropertyInclusion(JsonInclude.Include.ALWAYS);
     }
 }

src/main/java/graphql/servlet/GraphQLObjectMapper.java

@@ -1,6 +1,5 @@
 package graphql.servlet;
 
-import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.MappingIterator;
@@ -45,8 +44,7 @@ public ObjectMapper getJacksonMapper() {
             synchronized(this) {
                 result = mapper;
                 if (result == null) { // Second check (with locking)
-                    mapper = result = objectMapperProvider.provide().copy();
-                    mapper.setDefaultPropertyInclusion(JsonInclude.Include.ALWAYS);
+                    mapper = result = objectMapperProvider.provide();
                 }
             }
         }