Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL statements should not have PostgreSQL schema names hardcoded #3502

Open
bczerwinski-equinix opened this issue Nov 30, 2023 · 2 comments · Fixed by #3505
Open

SQL statements should not have PostgreSQL schema names hardcoded #3502

bczerwinski-equinix opened this issue Nov 30, 2023 · 2 comments · Fixed by #3505
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bczerwinski-equinix
Copy link
Contributor

As found in the following scripts:
https://github.com/kamilkisiela/graphql-hive/tree/main/packages/migrations/src/actions
https://github.com/kamilkisiela/graphql-hive/tree/main/packages/migrations/src/clickhouse-actions

There are PostgreSQL schemas names hardcoded (like public). This collides with PostgreSQL user (role) specific search_path setting, causing errors when executing migrations and some specific schema is set using search_path.

@n1ru4l n1ru4l added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 30, 2023
@bczerwinski-equinix bczerwinski-equinix changed the title Migrations SQL scripts should not have PostgreSQL schema names hardcoded SQL statements should not have PostgreSQL schema names hardcoded Nov 30, 2023
@bczerwinski-equinix
Copy link
Contributor Author

@n1ru4l I have searched though the entire project and for " public." (https://github.com/search?q=repo%3Akamilkisiela%2Fgraphql-hive+%22+public.%22&type=code) found multiple types of SQL statements where at least public schema is being used.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 30, 2023

@bczerwinski-equinix We can safely remove all these public references!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants