Skip to content

Validate if the graft chain contains any incompatible spec version #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

incrypto32
Copy link
Member

No description provided.

@lutter
Copy link
Collaborator

lutter commented Mar 26, 2025

Is this to avoid an error when going from old stable hash to fast stable hash? Could we just convert the old format into the new one and let people graft across these versions? As long as the conversion is deterministic, the resulting PoI should also be deterministic since the graft point is fixed

@incrypto32
Copy link
Member Author

@lutter this is a completely unrelated PR, this is to prevent people from using subgraphs that graft on subgraphs with specVersion lower than 1.3.0 as source subgraphs for composed subgraphs to ensure consistency of the vid ordering

@lutter
Copy link
Collaborator

lutter commented Mar 26, 2025

@lutter this is a completely unrelated PR, this is to prevent people from using subgraphs that graft on subgraphs with specVersion lower than 1.3.0 as source subgraphs for composed subgraphs to ensure consistency of the vid ordering

Aah .. thanks for explaining. I totally missed that

@incrypto32 incrypto32 force-pushed the krishna/sc-graft-chain branch from a234d94 to 0f9d42b Compare March 31, 2025 08:21
Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@incrypto32 incrypto32 merged commit 127d15c into master Mar 31, 2025
6 checks passed
@incrypto32 incrypto32 deleted the krishna/sc-graft-chain branch March 31, 2025 09:40
shiyasmohd pushed a commit that referenced this pull request Apr 17, 2025
… spec version (#5911)

* graph: Validate if the graft chain contains any incompatible spec version for composed subgraphs

* graph: allow subgraphs with prune set to never to be sourcable

* graph: remove the pruning check completely for source subgraphs

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants