-
Notifications
You must be signed in to change notification settings - Fork 1k
Validate if the graft chain contains any incompatible spec version #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sion for composed subgraphs
Is this to avoid an error when going from old stable hash to fast stable hash? Could we just convert the old format into the new one and let people graft across these versions? As long as the conversion is deterministic, the resulting PoI should also be deterministic since the graft point is fixed |
@lutter this is a completely unrelated PR, this is to prevent people from using subgraphs that graft on subgraphs with specVersion lower than 1.3.0 as source subgraphs for composed subgraphs to ensure consistency of the vid ordering |
Aah .. thanks for explaining. I totally missed that |
a234d94
to
0f9d42b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
… spec version (#5911) * graph: Validate if the graft chain contains any incompatible spec version for composed subgraphs * graph: allow subgraphs with prune set to never to be sourcable * graph: remove the pruning check completely for source subgraphs * Address review comments
No description provided.