Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bounding box for route #53

Closed
karussell opened this issue Apr 6, 2021 · 2 comments
Closed

Improve bounding box for route #53

karussell opened this issue Apr 6, 2021 · 2 comments
Milestone

Comments

@karussell
Copy link
Member

karussell commented Apr 6, 2021

There are several things we can improve:

@Janekdererste
Copy link
Collaborator

The bounding box should have a minimum size and it should always include the markers

@easbar
Copy link
Member

easbar commented Jun 15, 2021

Another problem is that the elevation widget might cover one of the query points, for example here:

https://graphhopper.com/maps2/?point=48.118447%2C11.539497&point=51.442113%2C14.265179&profile=car

So we should probably only take into account the available vertical space above the widget, and only use the entire vertical space when the widget is closed.

@easbar easbar mentioned this issue Jun 19, 2021
6 tasks
@karussell karussell modified the milestones: 0.4, 0.5 Nov 3, 2021
karussell added a commit that referenced this issue Jun 3, 2022
karussell added a commit that referenced this issue Jun 7, 2022
* grow bbox due to points, for #150

* grow bbox when too small, for #53

* code format
ZeroGxMax pushed a commit to minhhpkp/graphhopper-maps that referenced this issue Nov 12, 2024
* grow bbox due to points, for graphhopper#150

* grow bbox when too small, for graphhopper#53

* code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants