rework the client-side API, remove the Resolver, make Browse and Lookup package-level functions#100
Open
marten-seemann wants to merge 3 commits intograndcat:masterfrom
Open
rework the client-side API, remove the Resolver, make Browse and Lookup package-level functions#100marten-seemann wants to merge 3 commits intograndcat:masterfrom
marten-seemann wants to merge 3 commits intograndcat:masterfrom
Conversation
Contributor
Author
|
@grandcat Any thoughts on this PR? Anything I can do to move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements suggestion 1 in #98. Fixes #98.
I'm not entirely sure if this is the right way to go, but at least it seems to make the API a lot more intuitive. Also, it allows for a clean shutdown of all Go routines: As soon as
Lookup/Browsereturn, you can now be certain that no more Go routines are running in the background.