fix: attempt at fixing dangling pointer problem with themember net::FullyConnectToNet()

Author: gramcracker

examples/Ex3_CloneAndConnectNets.cpp

@@ -11,12 +11,12 @@ int main(){
 	vector <double> in{ 0, 2, 3};
 	vector <double> out{ 1, 0, .5, 0};
 	net n1(dims, true);//creates fully connected net with weights initialized to random values in the shape of dims
-	n1.TrainBackpropagation( out, in);//run backpropagation once
 	cout<<"n1:"<<endl;
 	for (int i= 0; i<n1.get_size(); i++){
 		cout<<"layer "<<i<<" = "<<n1.get_size(i)<<endl;
 	}
 
+
 	net n2 = n1;
 	cout<<"n2:"<<endl;
 	for (int i= 0; i<n2.get_size(); i++){
@@ -33,10 +33,17 @@ int main(){
 	n3.AppendNet(&n2,false);
 
 	cout<<"n3:"<<endl;
-	for (int i= 0; i<n3->get_size(); i++){
-		cout<<"layer "<<i<<" = "<<n3->get_size(i)<<endl;
+	for (int i= 0; i<n3.get_size(); i++){
+		cout<<"layer "<<i<<" = "<<n3.get_size(i)<<endl;
 	}
-	
+
+	n3.TrainBackpropagation(out,in);
+	cout<<endl<<"n1 output = ";
+	n1.Output();
+	cout<<endl<<"n2 output = ";
+	n2.Output();
+	cout<<endl<<"n3 output = ";
+	n3.Output();
 
 
 	return 0;

header/net.h

@@ -39,8 +39,6 @@ class net //represents a the vector of vectors of neurons
         int col;
         bool isnetfunc=false;
 
-
-
         union
         {
             //pointer to function to run
@@ -92,6 +90,7 @@ class net //represents a the vector of vectors of neurons
   vector<double> input;
   typedef vector <string> group;
   vector<group>groups;
+  bool netPointersCopied=false;
   //vector<thread> threads;
 
 

src/net.cpp

@@ -64,6 +64,10 @@ net::net(vector <int> &dimensions, bool fullyconnected)
 //destructor
 net::~net()
     {
+        if(this->netPointersCopied){
+            cout <<endl<<"netPointersCopied";
+            return;
+        }
         //deletes all neurons and their inweights
         for(row=layers.begin(); row!=layers.end(); row++)
         {
@@ -803,11 +807,12 @@ net* net::AppendNet(net* net_from, bool pasteOver)
             this->layers.resize(0);
             this->layers.insert(this->layers.end(), l.begin(), l.end());
 
+
     }else{
         this->layers.insert(this->layers.end(), net_from->layers.begin(), net_from->layers.end());
     }
 
-
+    net_from->netPointersCopied = true;
     return this;
 }