-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grails 5.1.6: integration tests, bootRun, bootWar are broken #12460
Comments
Downgrade from Spring Framework 5.3.18 to 5.3.17, and Spring Boot 2.6.5 build and released with 5.3.17, waiting for next Grails release based on Spring Boot 2.6.6 and Spring Framework 5.3.18. Update
|
+1 from me - would like to do the upgrade to get Spring's mitigation for Spring4Shell, but currently cannot |
Same issue here. |
Same issue here, upgrade from 5.1.5 to 5.1.6 by just change gradle.properties and didn't change any other settings, meet same issue |
BTW: Seems the security issue has been fixed on springboot 2.6.6, not 2.6.5, am I missing something https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement |
I have a workaround to fix this error, see the demo here -> |
@rainboyan I am surprised that it breaks after updating the Spring and Spring Boot version for Grails as that is the only change between 5.1.5 and 5.1.6. I would like to investigate further that why it is broken now. |
@puneetbehl related Spring Framework issue here: spring-projects/spring-framework#28261 |
Grails 4 app could be upgrade to Spring Framework 5.3.18, I create another demo here, it works with |
Hi Team, Is there any update to this issue or anything we can do to help on resolving this issue? Thanks. |
We are still working through the framework-wide implications of this issue. Spring has labeled the upstream issue as a regression. Current experimentation with Spring Core 5.3.19-SNAPSHOT has been yielding positive results. Presuming that the official release of Spring Core 5.3.19 resolves this issue and does not introduce any other complications, we will be releasing a new Grails 5.1 to use the updated dependency from Spring. |
Spring Framework 5.3.19 will be released on April 13, 2022, Spring Boot 2.6.7 will be released on April 21, 2022. |
Spring Framework 5.3.19 and 5.2.21 are available now
|
My Grails 5.1.6 app was failing due to this issue. However, when I upgrade Spring by using |
I can confirm
fixes this issue. I can also confirm Grails 5.1.6 points to Spring Boot 2.6.4 @JasonTypesCodes Considering 5.1.6 is completely broken and doesn't even point to the correct version, I would recommend releasing 5.1.7 as soon as possible. Otherwise, anyone attempting to use the latest version of Grails will be banging their head against the wall. |
I can confirm Grails 5.1.7 fixes this issue and points to Spring 5.3.19 but it still points to Spring Boot 2.6.4 |
@codeconsole There is an easy way to set spring-boot version in Grails project, the reason why Grails 5.1.7 still points to Spring Boot 2.6.4 could be found in the comments #12472.
|
@rainboyan adding your spring boot 2.6.6. workaround breaks Grails 5.1.7 with the previous error
|
@codeconsole Sorry for the missing part, the full Gradle build script is: Until Spring Boot 2.6.7 have been released, you should manually upgrade the Spring Framework dependency in your Spring Boot application. To override the Spring Framework version in your Maven or Gradle build, you should use the In
|
@rainboyan thanks, I incorrectly assumes 2.6.6 used 5.3.19 What's the point of the large Using just
works for me. |
@codeconsole my pleasure. Spring Boot and Micronaut use different version |
@puneetbehl Do you plan to release a new Grails version using Spring Framework 5.3.19 and Spring Boot 2.6.7? |
Yes, there will be a Grails 5.2.0 release soon. However, this error should be resolved with Grails 5.1.7 which updates to Spring 5.3.19. |
@puneetbehl Grails 5.2 branch will based on Spring Boot 2.6.x or 2.7.x? last week, Spring Boot 2.7.0-RC1 has been released, and will be GA next month. I also noticed that Grails 6.0.x branch was created, switch to Groovy 4, is that will be using Spring Boot 3.0? https://github.com/grails/grails-core/wiki/Roadmap was outdated a lot, the goals for the next phase should be updated. |
Grails 5.2 will be based on 2.6. We would probably do another minor release of Grails 5 once 2.7 is released. |
I will update the roadmap soon. Also, the feedback from the community is always welcome regardless we use Github projects or not. In the past, I tried to use the Github Project but I wasn't able to keep up with it. I will try to give it another try and also discuss the same in Grails Engineering Meeting next week. Thanks! |
@puneetbehl thanks for your reply. thank you for your hard work. Very much looking forward to Grails 6, and seeing the Team to talk about the big move. |
Expected Behavior
integration tests should run
bootRun gradle task should run
bootWar war product should run
Actual Behaviour
Exception is thrown:
Steps To Reproduce
Environment Information
OS: macos
JDK: openjdk version "1.8.0_302"
Example Application
No response
Version
5.1.6
The text was updated successfully, but these errors were encountered: