Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Close after sync on txt query #7

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Close after sync on txt query #7

merged 2 commits into from
Nov 8, 2023

Conversation

pimeys
Copy link
Collaborator

@pimeys pimeys commented Nov 7, 2023

We know node pg works with hyperdrive. What they do and we don't is they send a close message after syncing. Let's try that.

https://github.com/brianc/node-postgres/blob/master/packages/pg-protocol/src/serializer.ts#L264

This works with schema-registry tests muy bueno.

Copy link

@jakubadamw jakubadamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@pimeys pimeys merged commit 99908ea into grafbase Nov 8, 2023
@pimeys pimeys deleted the close-after-sync branch November 8, 2023 07:48
jakubadamw pushed a commit that referenced this pull request Mar 4, 2024
* close after sync on txt query

* fix: Try not to flush after describe
jakubadamw pushed a commit that referenced this pull request Mar 23, 2024
* close after sync on txt query

* fix: Try not to flush after describe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants