This repository was archived by the owner on Jan 30, 2025. It is now read-only.
WiP: Video capture #1234
Closed
WiP: Video capture #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablochacin
force-pushed
the
video-capture
branch
from
ba2bac6 to
ca3a976
Compare
pablochacin
force-pushed
the
video-capture
branch
from
ca3a976 to
e23edf3
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
video-capture
branch
from
e23edf3 to
04b1b19
Compare
pablochacin
requested review from
mstoykov and
ankur22
and removed request for
a team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements a video recording API for the browser using the screencast API to capture screens and ffmpeg for converting them into a video (similar approach used by puppeteer's screen recorder)
The functionality to start recording a video is added to the page interface. As it is not possible to have more than one active recording at a time, it was decided not to return a
screenrecorderobject as in the puppeter's API , but leave the functionality to control the active recording (basically, stop the recording) in the page object itself. Addopting pupperter's model would be relatively simple.Why?
Todo
Checklist
Related PR(s)/Issue(s)
Closes grafana/k6#4487