Fix navigation span end

ankur22 · ankur22 · commit c61a234c0971 · 2024-09-12T17:18:40.000+01:00
It looks like we weren't ending the span when a new navigation span was
being started.
diff --git a/common/frame_session.go b/common/frame_session.go
@@ -797,6 +797,11 @@ func (fs *FrameSession) processNavigationSpan(url string, id cdp.FrameID) {
 		return
 	}
 
+	// End the navigation span if it is non-nil
+	if fs.mainFrameSpan != nil {
+		fs.mainFrameSpan.End()
+	}
+
 	_, fs.mainFrameSpan = TraceNavigation(
 		fs.ctx, fs.targetID.String(), trace.WithAttributes(attribute.String("navigation.url", url)),
 	)

Original file line number	Diff line number	Diff line change
`@@ -797,6 +797,11 @@ func (fs *FrameSession) processNavigationSpan(url string, id cdp.FrameID) {`
`797`	`797`	`return`
`798`	`798`	`}`
`799`	`799`
	`800`	`+ // End the navigation span if it is non-nil`
	`801`	`+ if fs.mainFrameSpan != nil {`
	`802`	`+ fs.mainFrameSpan.End()`
	`803`	`+ }`
	`804`	`+`
`800`	`805`	`_, fs.mainFrameSpan = TraceNavigation(`
`801`	`806`	`fs.ctx, fs.targetID.String(), trace.WithAttributes(attribute.String("navigation.url", url)),`
`802`	`807`	`)`