-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues:
|
yvrhdn
changed the title
Experimental: Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus
Use OpenTelemetry tracer, bridge OpenTracing and OpenCensus
Jul 29, 2021
yvrhdn
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
July 30, 2021 11:48
mdisibio
reviewed
Aug 2, 2021
# Conflicts: # modules/frontend/frontend.go
mdisibio
approved these changes
Aug 6, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a new feature flag
use_otel_tracer
which replaces the OpenTracing tracer with the OpenTelemetry tracer. The OTel tracer will install two bridges (OpenTracing and OpenCensus) so all existing spans will be collected and sent.Why?
The feature flag defaults to false, i.e. keep using the OpenTracing tracer as before. There are a couple of issue we still need to iron out and not all features match (i.e. remote sampling is missing from the Jaeger exporter).
Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]