Tanka can't handle top level arrays #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielDyck
changed the title
GabrielDyck
changed the title
sh0rez
requested changes
Jul 17, 2020
| "testing" | ||
| ) | ||
|
|
||
| func TestEvalJsonnet(t *testing.T) { |
There was a problem hiding this comment.
Would love to see this also check objects, and evaluation results.
You could for example create multiple pseudo "environments" in testdata, like so:
- /
- /jsonnetfile.json
- /cases/
- /cases/array/main.jsonnet
- /cases/object/main.jsonnet
Then evaluate these as a table test, checking the error is nil and the result is what we expect.
Good work!
There was a problem hiding this comment.
Great! I'll add it. Thank you for your feedback.
|
@sh0rez all changes are ready. Let me know if it's ok. If you think it's ok, we could create another PR with a single commit for readability. |
added 2 commits
August 9, 2020 16:54
sh0rez
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sh0rez.
I'm glad to help with this issue #310. Please, let me know if I forgot something or we need to add anything else.