Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

chore: lint updates #705

Merged
merged 6 commits into from
May 23, 2023
Merged

chore: lint updates #705

merged 6 commits into from
May 23, 2023

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented May 22, 2023

  • Make rules more strict
  • Add some documentation to explain what the imports mean

@eh-am eh-am marked this pull request as ready for review May 22, 2023 14:02
Rustin170506
Rustin170506 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@eh-am @Rustin170506
Update public/README.md
2f4148a 
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
cyriltovena
cyriltovena approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyriltovena
cyriltovena approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eh-am eh-am merged commit acc6163 into main May 23, 2023
@eh-am eh-am deleted the chore/lint-updates branch May 23, 2023 11:03
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@eh-am
chore: lint updates (grafana/phlare#705)
dbdb0e7 
* Make rules more strict
* Add some documentation to explain what the imports mean

---------
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eh-am @cyriltovena @Rustin170506