Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify native histograms visualization and mark as experimental #9776

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

krajorama
Copy link
Contributor

What this PR does

Improve the documentation.
Clarify the status of the feature.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • N/A Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

Improve the documentation.
Clarify the status of the feature.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama added the type/docs Improvements or additions to documentation label Oct 30, 2024
@krajorama krajorama requested review from tacole02 and a team as code owners October 30, 2024 13:37
to be squashed

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Prometheus native histograms is a data type in the Prometheus ecosystem that makes it possible to produce, store, and query a high-resolution [histogram](https://prometheus.io/docs/concepts/metric_types/#histogram) of observations.
Native histograms are experimental and subject to change.

Prometheus native histograms is a new data type beside the existing floating point time series in the Prometheus ecosystem that makes it possible to produce, store, and query a high-resolution [histogram](https://prometheus.io/docs/concepts/metric_types/#histogram) of observations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Prometheus native histograms is a new data type beside the existing floating point time series in the Prometheus ecosystem that makes it possible to produce, store, and query a high-resolution [histogram](https://prometheus.io/docs/concepts/metric_types/#histogram) of observations.
Prometheus native histograms are a data type in the Prometheus ecosystem that allow you to produce, store, and query a high-resolution [histogram](https://prometheus.io/docs/concepts/metric_types/#histogram) of observations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit, beside the existing floating point time series, is confusing and makes this sentence difficult to parse. If this information is necessary, can we have it in a separate sentence that follows, i.e.

Prometheus native histograms are a data type in the Prometheus ecosystem that allow you to produce, store, and query a high-resolution histogram of observations. This data type extends the functionality of existing floating point time series.

Or something that like to preserve the intended meaning.

`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we should remove the new to keep the docs current over time.

Copy link

@leeoniya leeoniya Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data type extends the functionality of existing floating point time series.

this reads weird to me, since the data structs are fundmentally different. one is not a subset of the other. the same way that a graph is not an extension of a tree.

Copy link
Contributor

@tacole02 tacole02 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thank you for clarifying this. In this case, can we just remove the beside the existing floating point time series clause?

That would leave the following:

Prometheus native histograms are a data type in the Prometheus ecosystem that allow you to produce, store, and query a high-resolution histogram of observations.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
to squash

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @krajorama !

Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Good to me

Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
@krajorama krajorama enabled auto-merge (squash) November 8, 2024 14:07
@krajorama krajorama merged commit 65476c8 into main Nov 8, 2024
29 checks passed
@krajorama krajorama deleted the krajo/document-native-histograms branch November 8, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants