Skip to content

Conversation

@jesusvazquez
Copy link
Contributor

This PR is introducing the changes from #9131 , that are not yet in main, into release r303 as a backport.

@jesusvazquez jesusvazquez changed the base branch from main to r303 September 2, 2024 10:21
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesusvazquez jesusvazquez marked this pull request as ready for review September 2, 2024 13:26
@jesusvazquez jesusvazquez enabled auto-merge (squash) September 2, 2024 13:26
@krajorama krajorama closed this Sep 2, 2024
auto-merge was automatically disabled September 2, 2024 13:48

Pull request was closed

@krajorama krajorama reopened this Sep 2, 2024
@krajorama krajorama enabled auto-merge (squash) September 2, 2024 14:04
@krajorama krajorama merged commit 4a3d4a1 into r303 Sep 2, 2024
@krajorama krajorama deleted the jvp/otlp-convert-created-timestamps-to-prom-timestamps-for-r303 branch September 2, 2024 14:08
krajorama added a commit that referenced this pull request Sep 4, 2024
To allow connecting to the collector from outside docker network.
Not sure when this was changed, but latest docs include this:
https://opentelemetry.io/docs/collector/configuration/#basics

Discover while testing #9172

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama added a commit that referenced this pull request Sep 4, 2024
To allow connecting to the collector from outside docker network.
Not sure when this was changed, but latest docs include this:
https://opentelemetry.io/docs/collector/configuration/#basics

Discover while testing #9172

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants