Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: review and update of release process by tech writer #4500

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Helm: review and update of release process by tech writer #4500

merged 4 commits into from
Mar 29, 2023

Conversation

osg-grafana
Copy link
Contributor

No description provided.

@osg-grafana osg-grafana requested a review from a team as a code owner March 14, 2023 17:53
krajorama
krajorama previously approved these changes Mar 14, 2023
View reviewed changes
@osg-grafana osg-grafana added the type/docs Improvements or additions to documentation label Mar 14, 2023
@krajorama krajorama dismissed their stale review March 14, 2023 17:59

need to revisit the readme

@krajorama
Copy link
Contributor

Having looked at the README.md, I think it would be in our interest to make it version agnostic. So that we only have to deal with the actual documentation and links therein.

The simplest way would be to just replace the contents with a link to the Grafana Mimir Helm chart documentation, but maybe that's an overkill.

@osg-grafana
Copy link
Contributor Author

Having looked at the README.md, I think it would be in our interest to make it version agnostic. So that we only have to deal with the actual documentation and links therein.

The simplest way would be to just replace the contents with a link to the Grafana Mimir Helm chart documentation, but maybe that's an overkill.

I like this approach.

@osg-grafana
Copy link
Contributor Author

@krajorama, please approve my / your PR. :)

@osg-grafana
Copy link
Contributor Author

@krajorama is aware that this PR is still in progress, and it will be resolved as time allows.

@krajorama krajorama mentioned this pull request Mar 29, 2023
Open
dimitarvdimitrov
dimitarvdimitrov approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@osg-grafana osg-grafana force-pushed the osg-grafana-patch-2 branch from 1b74fdb to b43df45 Compare March 29, 2023 13:32
@krajorama krajorama changed the title Change Mimir to Mimir Helm chart Helm: review and update of release process by tech writer Mar 29, 2023
@krajorama krajorama enabled auto-merge (squash) March 29, 2023 13:44
@krajorama krajorama merged commit 6bb38b7 into main Mar 29, 2023
@krajorama krajorama deleted the osg-grafana-patch-2 branch March 29, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

@krajorama krajorama krajorama approved these changes

Assignees

@krajorama krajorama

@osg-grafana osg-grafana

Labels
type/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osg-grafana @krajorama @dimitarvdimitrov