helm: remove -server.grpc.keepalive.max-connection-idle from common config (#7298)

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

Author: narqo

operations/compare-helm-with-jsonnet/components/config/kustomization.yaml

@@ -148,14 +148,6 @@ patches:
       - op: remove
         path: /config/limits/max_total_query_length
 
-  - target:
-      kind: MimirConfig
-      name: 'alertmanager|compactor|ingester|overrides-exporter|querier|query-frontend|query-scheduler|ruler|store-gateway'
-    patch: |-
-      # Only applied to distributors in jsonnet, remove from the rest
-      - op: remove
-        path: /config/server/grpc_server_max_connection_idle
-
   - target:
       kind: MimirConfig
       name: 'alertmanager|compactor|distributor|ingester|overrides-exporter|querier|query-frontend|query-scheduler|ruler|store-gateway'

operations/helm/charts/mimir-distributed/CHANGELOG.md

@@ -40,6 +40,7 @@ Entries should include a reference to the Pull Request that introduced the chang
   * `-compactor.ring.heartbeat-timeout` set to `4m`
 * [CHANGE] Ruler: Set `-distributor.remote-timeout` to 10s in order to accommodate writing large rule results to the ingester. #7143
 * [CHANGE] Remove `-server.grpc.keepalive.max-connection-age` and `-server.grpc.keepalive.max-connection-age-grace` from default config. The configuration now applied directly to distributor, fixing parity with jsonnet. #7269
+* [CHANGE] Remove `-server.grpc.keepalive.max-connection-idle` from default config. The configuration now applied directly to distributor, fixing parity with jsonnet. #7298
 * [ENHANCEMENT] Add `jaegerReporterMaxQueueSize` Helm value for all components where configuring `JAEGER_REPORTER_MAX_QUEUE_SIZE` makes sense, and override the Jaeger client's default value of 100 for components expected to generate many trace spans. #7068 #7086 #7259
 * [ENHANCEMENT] Rollout-operator: upgraded to v0.10.1. #7125
 * [ENHANCEMENT] Query-frontend: configured `-shutdown-delay`, `-server.grpc.keepalive.max-connection-age` and termination grace period to reduce the likelihood of queries hitting terminated query-frontends. #7129

operations/helm/charts/mimir-distributed/templates/distributor/distributor-dep.yaml

@@ -50,6 +50,7 @@ spec:
             # Force gRPC clients connecting to distributor to reconnect periodically in order to have them re-resolve endpoints and discover new replicas.
             - "-server.grpc.keepalive.max-connection-age=2m"
             - "-server.grpc.keepalive.max-connection-age-grace=5m"
+            - "-server.grpc.keepalive.max-connection-idle=1m"
           {{- if .Values.ingester.zoneAwareReplication.migration.enabled }}
             {{- if not .Values.ingester.zoneAwareReplication.migration.writePath }}
             - "-ingester.ring.zone-awareness-enabled=false"

operations/helm/charts/mimir-distributed/values.yaml

@@ -374,9 +374,6 @@ mimir:
     runtime_config:
       file: /var/{{ include "mimir.name" . }}/runtime.yaml
 
-    server:
-      grpc_server_max_connection_idle: 1m
-
     store_gateway:
       sharding_ring:
         heartbeat_period: 1m

operations/helm/tests/enterprise-https-values-generated/mimir-distributed/templates/distributor/distributor-dep.yaml

@@ -57,6 +57,7 @@ spec:
             # Force gRPC clients connecting to distributor to reconnect periodically in order to have them re-resolve endpoints and discover new replicas.
             - "-server.grpc.keepalive.max-connection-age=2m"
             - "-server.grpc.keepalive.max-connection-age-grace=5m"
+            - "-server.grpc.keepalive.max-connection-idle=1m"
           volumeMounts:
 
             - mountPath: /certs

operations/helm/tests/enterprise-https-values-generated/mimir-distributed/templates/mimir-config.yaml

@@ -286,7 +286,6 @@ data:
     runtime_config:
       file: /var/mimir/runtime.yaml
     server:
-      grpc_server_max_connection_idle: 1m
       grpc_tls_config:
         cert_file: /certs/tls.crt
         client_auth_type: VerifyClientCertIfGiven

operations/helm/tests/gateway-enterprise-values-generated/mimir-distributed/templates/distributor/distributor-dep.yaml

@@ -57,6 +57,7 @@ spec:
             # Force gRPC clients connecting to distributor to reconnect periodically in order to have them re-resolve endpoints and discover new replicas.
             - "-server.grpc.keepalive.max-connection-age=2m"
             - "-server.grpc.keepalive.max-connection-age-grace=5m"
+            - "-server.grpc.keepalive.max-connection-idle=1m"
           volumeMounts:
             - name: config
               mountPath: /etc/mimir

operations/helm/tests/gateway-enterprise-values-generated/mimir-distributed/templates/mimir-config.yaml

@@ -148,8 +148,6 @@ data:
         secret_access_key: supersecret
     runtime_config:
       file: /var/mimir/runtime.yaml
-    server:
-      grpc_server_max_connection_idle: 1m
     store_gateway:
       sharding_ring:
         heartbeat_period: 1m

operations/helm/tests/gateway-nginx-values-generated/mimir-distributed/templates/distributor/distributor-dep.yaml

@@ -57,6 +57,7 @@ spec:
             # Force gRPC clients connecting to distributor to reconnect periodically in order to have them re-resolve endpoints and discover new replicas.
             - "-server.grpc.keepalive.max-connection-age=2m"
             - "-server.grpc.keepalive.max-connection-age-grace=5m"
+            - "-server.grpc.keepalive.max-connection-idle=1m"
           volumeMounts:
             - name: config
               mountPath: /etc/mimir

operations/helm/tests/gateway-nginx-values-generated/mimir-distributed/templates/mimir-config.yaml

@@ -104,8 +104,6 @@ data:
         secret_access_key: supersecret
     runtime_config:
       file: /var/mimir/runtime.yaml
-    server:
-      grpc_server_max_connection_idle: 1m
     store_gateway:
       sharding_ring:
         heartbeat_period: 1m