-
Notifications
You must be signed in to change notification settings - Fork 550
/
Copy pathvalidation_separate_metrics_test.go
257 lines (208 loc) · 9.28 KB
/
validation_separate_metrics_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
// SPDX-License-Identifier: AGPL-3.0-only
// Provenance-includes-location: https://github.com/cortexproject/cortex/blob/master/integration/ingester_limits_test.go
// Provenance-includes-license: Apache-2.0
// Provenance-includes-copyright: The Cortex Authors.
//go:build requires_docker
package integration
import (
"strconv"
"testing"
"time"
"github.com/grafana/e2e"
e2edb "github.com/grafana/e2e/db"
"github.com/prometheus/prometheus/model/labels"
"github.com/prometheus/prometheus/prompb"
"github.com/stretchr/testify/require"
"github.com/grafana/mimir/integration/e2emimir"
)
func TestValidateSeparateMetrics(t *testing.T) {
s, err := e2e.NewScenario(networkName)
require.NoError(t, err)
defer s.Close()
flags := mergeFlags(
BlocksStorageFlags(),
BlocksStorageS3Flags(),
)
flags["-validation.separate-metrics-group-label"] = "group_1"
// Start dependencies.
consul := e2edb.NewConsul()
minio := e2edb.NewMinio(9000, flags["-blocks-storage.s3.bucket-name"])
require.NoError(t, s.StartAndWaitReady(consul, minio))
// Start Mimir components.
distributor := e2emimir.NewDistributor("distributor", consul.NetworkHTTPEndpoint(), flags)
ingester1 := e2emimir.NewIngester("ingester-1", consul.NetworkHTTPEndpoint(), flags)
ingester2 := e2emimir.NewIngester("ingester-2", consul.NetworkHTTPEndpoint(), flags)
ingester3 := e2emimir.NewIngester("ingester-3", consul.NetworkHTTPEndpoint(), flags)
require.NoError(t, s.StartAndWaitReady(distributor, ingester1, ingester2, ingester3))
// Wait until distributor has updated the ring.
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(3), []string{"cortex_ring_members"}, e2e.WithLabelMatchers(
labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"),
labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE"))))
now := time.Now()
client, err := e2emimir.NewClient(distributor.HTTPEndpoint(), "", "", "", userID)
require.NoError(t, err)
// Push invalid metrics to increment cortex_discarded_samples_total
series, _, _ := generateFloatSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
}, prompb.Label{
Name: "group_1",
Value: "test-group",
})
pushTimeSeriesWithStatus(t, client, series, 400)
series, _, _ = generateHistogramSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
}, prompb.Label{
Name: "group_1",
Value: "test-group",
})
pushTimeSeriesWithStatus(t, client, series, 400)
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(2), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "test-group")),
))
// Push series with no group label
series, _, _ = generateFloatSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series, 400)
series, _, _ = generateHistogramSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series, 400)
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(2), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "")),
))
// Ensure previous series didn't disappear
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(2), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "test-group")),
))
// Push two series, group label only present in second series
series1, _, _ := generateFloatSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series1, 400)
series2, _, _ := generateHistogramSeries("TestMetric", now, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
}, prompb.Label{
Name: "group_1",
Value: "second-series",
})
pushTimeSeriesWithStatus(t, client, series2, 400)
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(3), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "")),
))
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "second-series")),
))
}
func TestPushMultipleInvalidLabels(t *testing.T) {
s, err := e2e.NewScenario(networkName)
require.NoError(t, err)
defer s.Close()
flags := mergeFlags(
BlocksStorageFlags(),
BlocksStorageS3Flags(),
)
flags["-validation.separate-metrics-group-label"] = "separate_metrics_group"
// Start dependencies.
consul := e2edb.NewConsul()
minio := e2edb.NewMinio(9000, flags["-blocks-storage.s3.bucket-name"])
require.NoError(t, s.StartAndWaitReady(consul, minio))
// Start Mimir components.
distributor := e2emimir.NewDistributor("distributor", consul.NetworkHTTPEndpoint(), flags)
ingester1 := e2emimir.NewIngester("ingester-1", consul.NetworkHTTPEndpoint(), flags)
ingester2 := e2emimir.NewIngester("ingester-2", consul.NetworkHTTPEndpoint(), flags)
ingester3 := e2emimir.NewIngester("ingester-3", consul.NetworkHTTPEndpoint(), flags)
require.NoError(t, s.StartAndWaitReady(distributor, ingester1, ingester2, ingester3))
// Wait until distributor has updated the ring.
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(3), []string{"cortex_ring_members"}, e2e.WithLabelMatchers(
labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"),
labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE"))))
client, err := e2emimir.NewClient(distributor.HTTPEndpoint(), "", "", "", userID)
require.NoError(t, err)
// Push invalid series with different groups
for i := 0; i < 9; i++ {
series, _, _ := generateAlternatingSeries(i)("TestMetric", time.Now(), prompb.Label{
Name: "separate_metrics_group",
Value: strconv.Itoa(i % 2),
}, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series, 400)
}
// Odd group values
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(4), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "1")),
))
// Even group values
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(5), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "0")),
))
}
func TestSeparateMetricsGroupLimitExceeded(t *testing.T) {
s, err := e2e.NewScenario(networkName)
require.NoError(t, err)
defer s.Close()
flags := mergeFlags(
BlocksStorageFlags(),
BlocksStorageS3Flags(),
)
flags["-validation.separate-metrics-group-label"] = "separate_metrics_group"
flags["-max-separate-metrics-groups-per-user"] = strconv.Itoa(10)
// Start dependencies.
consul := e2edb.NewConsul()
minio := e2edb.NewMinio(9000, flags["-blocks-storage.s3.bucket-name"])
require.NoError(t, s.StartAndWaitReady(consul, minio))
// Start Mimir components.
distributor := e2emimir.NewDistributor("distributor", consul.NetworkHTTPEndpoint(), flags)
ingester1 := e2emimir.NewIngester("ingester-1", consul.NetworkHTTPEndpoint(), flags)
ingester2 := e2emimir.NewIngester("ingester-2", consul.NetworkHTTPEndpoint(), flags)
ingester3 := e2emimir.NewIngester("ingester-3", consul.NetworkHTTPEndpoint(), flags)
require.NoError(t, s.StartAndWaitReady(distributor, ingester1, ingester2, ingester3))
// Wait until distributor has updated the ring.
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(3), []string{"cortex_ring_members"}, e2e.WithLabelMatchers(
labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"),
labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE"))))
client, err := e2emimir.NewClient(distributor.HTTPEndpoint(), "", "", "", userID)
require.NoError(t, err)
// Push invalid series with different groups
now := time.Now()
for i := 0; i < 10; i++ {
series, _, _ := generateAlternatingSeries(i)("TestMetric", now, prompb.Label{
Name: "separate_metrics_group",
Value: strconv.Itoa(i),
}, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series, 400)
}
// Push another series which should be registered as group "other" as active group limit exceeded
series, _, _ := generateFloatSeries("TestMetric", now, prompb.Label{
Name: "separate_metrics_group",
Value: "group_limit_exceeded",
}, prompb.Label{
Name: "Test|Invalid|Label|Char",
Value: "123",
})
pushTimeSeriesWithStatus(t, client, series, 400)
for i := 0; i < 10; i++ {
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", strconv.Itoa(i))),
))
}
require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_discarded_samples_total"},
e2e.WithLabelMatchers(labels.MustNewMatcher(labels.MatchEqual, "group", "other")),
))
}
func pushTimeSeriesWithStatus(t *testing.T, client *e2emimir.Client, timeSeries []prompb.TimeSeries, expectedStatusCode int) {
res, err := client.Push(timeSeries)
require.NoError(t, err)
require.Equal(t, expectedStatusCode, res.StatusCode)
}