-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Add healthckecks in docker example #7731
Conversation
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
@bitkill thanks for the PR. Two clarifications.
|
I wanted to be able to have a better base for testing loki locally, and waiting for the systems to be healthy is a good way to automate some tests that I am running.
These were a bit arbitrary, just tried to make the initial wait time (for all services to be healthy) fast, so it wouldn't take a long time just because we are waiting 30s between checks. |
@kavirajk forgot to tag you in the response yesterday. response above ☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for the clarification!
**What this PR does / why we need it**: Adds healthchecks for the loki `docker compose` example, this makes the getting started example more complete, and can be now used with the `--wait` command. **Special notes for your reviewer**: Use the following commands to test: ```sh cd examples/getting-started docker compose up -d --wait docker compose ps ``` **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] `CHANGELOG.md` updated
What this PR does / why we need it:
Adds healthchecks for the loki
docker compose
example, this makes the getting started example more complete,and can be now used with the
--wait
command.Special notes for your reviewer:
Use the following commands to test:
cd examples/getting-started docker compose up -d --wait docker compose ps
Checklist
CONTRIBUTING.md
guideCHANGELOG.md
updated