Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAINTAINERS.md #7467

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Update MAINTAINERS.md #7467

merged 2 commits into from
Oct 19, 2022

Conversation

osg-grafana
Copy link
Contributor

@osg-grafana osg-grafana commented Oct 19, 2022

This change removes removes Karen Miller, and includes at least one alternative, interim technical writer.

@osg-grafana osg-grafana requested a review from a team as a code owner October 19, 2022 11:07
@osg-grafana osg-grafana self-assigned this Oct 19, 2022
@osg-grafana osg-grafana added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 19, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0.4%
+               loki	0%

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

MAINTAINERS.md Outdated Show resolved Hide resolved
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
@github-actions github-actions bot removed the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 19, 2022
@osg-grafana
Copy link
Contributor Author

Hi @slim-bean, because this touches maintainers, may I have a second +1?

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dannykopping dannykopping merged commit 709c850 into main Oct 19, 2022
@dannykopping dannykopping deleted the osg-grafana-patch-2 branch October 19, 2022 11:32
lxwzy pushed a commit to lxwzy/loki that referenced this pull request Nov 7, 2022
This change removes removes Karen Miller, and includes at least one
alternative, interim technical writer.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
changhyuni pushed a commit to changhyuni/loki that referenced this pull request Nov 8, 2022
This change removes removes Karen Miller, and includes at least one
alternative, interim technical writer.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Abuelodelanada pushed a commit to canonical/loki that referenced this pull request Dec 1, 2022
This change removes removes Karen Miller, and includes at least one
alternative, interim technical writer.

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants