Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsdb/wal rotate fix #6423

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Tsdb/wal rotate fix #6423

merged 2 commits into from
Jun 17, 2022

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jun 17, 2022

Fixes an issue where we'd optimistically release the lock during tsdb headmanager rotations. Now we'll lock for the entire process and double check conditions.

ref #5428

owen-d added 2 commits June 17, 2022 11:56
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…nager

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner June 17, 2022 16:29
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

@owen-d owen-d merged commit a1c72ad into grafana:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants