Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsdb/index sampling endpoint #6347

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jun 8, 2022

Wires up a new endpoint (``/loki/api/v1/index/stats) for querying the index with ([]matcher, from, through)`:

$ curl -s localhost:3100/loki/api/v1/index/stats?query=%7Bfilename%3D~%22.%2B%22%7D | jq '.'
{
  "streams": 2,
  "chunks": 17,
  "bytes": 0, # guessing this is zero b/c none of my test data rounded up to a KB for inclusion here
  "entries": 794
}

ref #5428

@owen-d owen-d marked this pull request as ready for review June 8, 2022 21:45
@owen-d owen-d requested review from KMiller-Grafana and a team as code owners June 8, 2022 21:45
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
-            querier	-2.9%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a question

pkg/storage/stores/tsdb/multitenant.go Show resolved Hide resolved
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
-            querier	-2.9%
- querier/queryrange	-0.1%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM very exciting

@owen-d owen-d merged commit 3f4a663 into grafana:main Jun 9, 2022
@osg-grafana osg-grafana added type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories and removed area/docs labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants