-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluentd): allow fluentd_thread label to be configurable #6240
Conversation
b178529
to
5462205
Compare
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea presented here looks good to me, but I'm not ruby expert :( . Now that loki accepts out of order data by default, this label isn't necessary in most scenarios.
cc @cyriltovena hopefully can give you an approval as well.
Signed-off-by: Trevor Wood Trevor.G.Wood@gmail.com
What this PR does / why we need it:
This PR allows the
fluentd_thread
label included when multi-threading flushing is enabled to be configurable. The label will be included by default in order to preserve backwards compatibility.Which issue(s) this PR fixes:
Fixes #5336
Special notes for your reviewer:
Checklist
CHANGELOG.md
.docs/sources/upgrading/_index.md
-- N/A