Fix(query-frontend): LokiCodec encode/decode works correctly with label values endpoint #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el values endpoint
When encode/decode `http.Request` into `querybase.Request` we re-create request.Path.
Before this PR, both `/labels/` and `/labels/{name}/values` endpoint was decoding into same URL path `/labels/` before
forwarding to the querier. So it always returns label names as response.
This bug became visible after enabling all the middleware for `/labels/{name}/values` endpoint as well via #6072
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
cyriltovena
approved these changes
May 3, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When encode/decode
http.Requestintoquerybase.Requestwe re-create request.Path.Before this PR, both
/labels/and/labels/{name}/valuesendpoint was decoding into same URL path/labels/beforeforwarding to the querier. So it always returns label names as response.
This bug became visible after enabling all the middleware for
/labels/{name}/valuesendpoint as well via #6072Signed-off-by: Kaviraj kavirajkanagaraj@gmail.com
Which issue(s) this PR fixes:
Fixes # NA.
Special notes for your reviewer:
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md