Ensure proto definitions are formatted [2/2] #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20220422_add-proto-formatting-build-image
branch
2 times, most recently
from
7e921dd
to
7a8ec00
Compare
simonswine
changed the title
simonswine
force-pushed
the
20220422_add-proto-formatting-build-image
branch
from
7a8ec00
to
aa3e3d7
Compare
This uses buf to ensure the proto defintions are more consistently formatted.
simonswine
force-pushed
the
20220422_add-proto-formatting-build-image
branch
from
aa3e3d7
to
64b1d28
Compare
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It will ensure that our proto files follow a consistent formatting throughout.
This PR adds the makefile targets for formatting and updates the build image to the new version.
Special notes for your reviewer:
This is the second in a series two PRs (do not merge before #5785 is merged)
Checklist
- [ ] Documentation added- [ ] Tests updated- [ ] Add an entry in theCHANGELOG.mdabout the changes.